Skip to content

Clean up python2 related code crafts #974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 10, 2021
Merged

Conversation

auvipy
Copy link
Contributor

@auvipy auvipy commented Sep 10, 2021

Fixes #

Description of the Change

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

@codecov
Copy link

codecov bot commented Sep 10, 2021

Codecov Report

Merging #974 (f78901b) into master (50841f7) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #974   +/-   ##
=======================================
  Coverage   96.82%   96.82%           
=======================================
  Files          65       65           
  Lines        3904     3904           
=======================================
  Hits         3780     3780           
  Misses        124      124           
Impacted Files Coverage Δ
rest_framework_json_api/relations.py 88.46% <100.00%> (ø)
rest_framework_json_api/renderers.py 90.15% <100.00%> (ø)
rest_framework_json_api/settings.py 100.00% <100.00%> (ø)
example/serializers.py 89.14% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50841f7...f78901b. Read the comment docs.

Copy link
Member

@sliverc sliverc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this clean up task. Really appreciated. Could you please run black . and push again? Then it will be ready for merging.

@auvipy
Copy link
Contributor Author

auvipy commented Sep 10, 2021

OK sure

@auvipy
Copy link
Contributor Author

auvipy commented Sep 10, 2021

pushed new changes

Copy link
Member

@sliverc sliverc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. LGTM.

@sliverc sliverc merged commit e1feedc into django-json-api:master Sep 10, 2021
@auvipy auvipy deleted the py2drop branch September 10, 2021 15:12
@auvipy
Copy link
Contributor Author

auvipy commented Sep 10, 2021

would be happy to help. thanks for this cool project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants