Skip to content

Documented how to add DJA to installed apps #963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 26, 2021

Conversation

sliverc
Copy link
Member

@sliverc sliverc commented Jul 20, 2021

Description of the Change

This setting is now needed for browsable api and openapi schema. There might be more features coming needing this and it is also common practice to do this for django apps.

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

@codecov
Copy link

codecov bot commented Jul 20, 2021

Codecov Report

Merging #963 (8c1a624) into master (4c62f1d) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #963      +/-   ##
==========================================
- Coverage   96.82%   96.78%   -0.04%     
==========================================
  Files          65       65              
  Lines        3904     3857      -47     
==========================================
- Hits         3780     3733      -47     
  Misses        124      124              
Impacted Files Coverage Δ
example/serializers.py 88.82% <0.00%> (-0.32%) ⬇️
rest_framework_json_api/renderers.py 89.96% <0.00%> (-0.20%) ⬇️
rest_framework_json_api/relations.py 88.34% <0.00%> (-0.12%) ⬇️
rest_framework_json_api/parsers.py 98.48% <0.00%> (-0.07%) ⬇️
tests/conftest.py 100.00% <0.00%> (ø)
tests/test_views.py 100.00% <0.00%> (ø)
example/factories.py 100.00% <0.00%> (ø)
example/tests/test_errors.py 100.00% <0.00%> (ø)
example/tests/test_openapi.py 100.00% <0.00%> (ø)
example/api/resources/identity.py 100.00% <0.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c62f1d...8c1a624. Read the comment docs.

This setting is now needed for browsable api and openapi schema.
There might be more features coming needing this and it is also
common practice to do this for django apps.
@sliverc sliverc force-pushed the installed_apps_setting branch from d7bbafa to 9b1474e Compare July 20, 2021 18:47
@sliverc sliverc marked this pull request as ready for review July 20, 2021 18:49
@sliverc sliverc requested a review from n2ygk July 20, 2021 18:49
@n2ygk n2ygk merged commit d20247f into django-json-api:master Jul 26, 2021
@sliverc sliverc deleted the installed_apps_setting branch December 28, 2021 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants