Skip to content

Resolve warning of inconsistent result when calling LabResults view #959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2021

Conversation

sliverc
Copy link
Member

@sliverc sliverc commented Jul 14, 2021

Description of the Change

As LabResults is used in a test with pagination, a default ordering is required to omit warning about unpredictable order when running pytest.

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

@sliverc sliverc requested a review from n2ygk July 14, 2021 13:08
@codecov
Copy link

codecov bot commented Jul 14, 2021

Codecov Report

Merging #959 (c0a3d23) into master (cb023fc) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #959   +/-   ##
=======================================
  Coverage   96.81%   96.81%           
=======================================
  Files          64       65    +1     
  Lines        3888     3894    +6     
=======================================
+ Hits         3764     3770    +6     
  Misses        124      124           
Impacted Files Coverage Δ
example/migrations/0010_auto_20210714_0809.py 100.00% <100.00%> (ø)
example/models.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb023fc...c0a3d23. Read the comment docs.

As LabResults is used in a test with pagination, a default ordering is
required to omit warning about unpredictable order.
@sliverc sliverc changed the title Resolve warning of inconsistent result when call LabResults view Resolve warning of inconsistent result when calling LabResults view Jul 14, 2021
@n2ygk n2ygk merged commit 684063b into django-json-api:master Jul 16, 2021
@sliverc sliverc deleted the solve_warning branch July 16, 2021 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants