Skip to content

Avoided error when using include query parameter on related urls #914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 23, 2021

Conversation

sliverc
Copy link
Member

@sliverc sliverc commented Apr 16, 2021

Description of the Change

Using include on related urls always through an error even when correctly configured.
This is a regression of version 4.1.0.

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

@sliverc sliverc requested a review from n2ygk April 16, 2021 13:36
@codecov
Copy link

codecov bot commented Apr 16, 2021

Codecov Report

Merging #914 (a76396b) into master (36a60a3) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #914   +/-   ##
=======================================
  Coverage   97.67%   97.67%           
=======================================
  Files          58       58           
  Lines        3093     3102    +9     
=======================================
+ Hits         3021     3030    +9     
  Misses         72       72           
Impacted Files Coverage Δ
example/tests/integration/test_browsable_api.py 100.00% <100.00%> (ø)
rest_framework_json_api/renderers.py 90.15% <100.00%> (+0.06%) ⬆️
tests/test_views.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36a60a3...a76396b. Read the comment docs.

@sliverc sliverc mentioned this pull request Apr 16, 2021
5 tasks
Copy link
Contributor

@n2ygk n2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@n2ygk n2ygk merged commit 7d2970a into django-json-api:master Apr 23, 2021
@sliverc sliverc deleted the include_related_field branch December 28, 2021 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants