Create security policy #893
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #893 +/- ##
=======================================
Coverage 97.70% 97.70%
=======================================
Files 59 59
Lines 3182 3182
=======================================
Hits 3109 3109
Misses 73 73 Continue to review full report at Codecov.
|
n2ygk
requested changes
Mar 8, 2021
sliverc
force-pushed
the
security-policy
branch
from
f90d6e7 to
8e5d789
Compare
|
@n2ygk I have added you to the security mailing list and also updated the PR with more details. Ready for review again. |
|
@n2ygk Could you have a look again at this PR? Thanks. |
n2ygk
requested changes
Mar 16, 2021
Replace invalid email address
Add missing space
Clarify add maintainer description.
n2ygk
approved these changes
Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
We did not have any security issues in the past but there might be so I think it is important to have a security policy so users know how to report such with fully disclosing it in a GitHub issue. After all DJA exposes APIs which could be publicly exposed.
I've copied the policy from Django REST Framework and adjusted it. I recommend to read following guide which describes how security vulnerabilities are best addressed.
One question remains though is what means do we wanna use to privately communicate with us? Github has Security Advisories which I recommend we use. But only a admin can create security advisories. Currently as it seems GitHub does not provide a way for the initial communication.
DRF uses googlegroups for this. Not my favorite but do not see a alternatives. Or are there any other suggestions?
Checklist
CHANGELOG.mdupdated (only for user relevant changes)AUTHORS