Skip to content

Render meta fields of included resource #883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 10, 2021

Conversation

mast22
Copy link
Contributor

@mast22 mast22 commented Jan 13, 2021

Description of the Change

When adding serializer as a field the meta fields are not rendered, This change provides the rendering capability, test and some fixes of related tests.

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

@codecov
Copy link

codecov bot commented Jan 13, 2021

Codecov Report

Merging #883 (95bd302) into master (952e26b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #883   +/-   ##
=======================================
  Coverage   97.80%   97.80%           
=======================================
  Files          60       60           
  Lines        3321     3325    +4     
=======================================
+ Hits         3248     3252    +4     
  Misses         73       73           
Impacted Files Coverage Δ
example/tests/test_format_keys.py 100.00% <ø> (ø)
example/tests/test_serializers.py 100.00% <ø> (ø)
example/tests/integration/test_includes.py 100.00% <100.00%> (ø)
example/tests/unit/test_renderer_class_methods.py 100.00% <100.00%> (ø)
rest_framework_json_api/renderers.py 90.09% <100.00%> (-0.10%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 952e26b...3a3032a. Read the comment docs.

Copy link
Member

@sliverc sliverc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this PR. This brings certainly more consistency to DJA.

I have added some inline comments. Please also add a changelog entry. Thanks.

@sliverc sliverc force-pushed the add-meta-object-to-included branch from 75c4d42 to 3a3032a Compare February 10, 2021 18:35
@sliverc
Copy link
Member

sliverc commented Feb 10, 2021

Thanks for your contributions. As mentioned above I adjusted your PR a bit but all the rest looked good and ready for merging.

@sliverc sliverc merged commit 5488b18 into django-json-api:master Feb 10, 2021
@mast22
Copy link
Contributor Author

mast22 commented Mar 16, 2021

Thanks, and sorry I could not complete it myself. Glad i could help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants