-
Notifications
You must be signed in to change notification settings - Fork 301
Format code with black #862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #862 +/- ##
=======================================
Coverage 97.74% 97.74%
=======================================
Files 60 60
Lines 3319 3319
=======================================
Hits 3244 3244
Misses 75 75
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry it took me so long to get to this.
If you can make sure auto-generated files are not reformatted, that would be great. Otherwise we'll have a bunch unnecessary diffs.
@@ -15,7 +15,6 @@ | |||
|
|||
import datetime | |||
import os | |||
import shlex |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add this to an exceptions file that black won't fix? conf.py is autogenerated by sphinx-quickstart
and then edited manually after that.
@@ -2,93 +2,154 @@ | |||
# Generated by Django 1.9.5 on 2016-05-02 08:26 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As above, exclude migrations.
@@ -4,116 +4,97 @@ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also exclude auto-generated snapshots
Thanks for having a look at this. I deliberately formatted the generated files as well because:
Does this makes sense? |
Fixes #857
Description of the Change
Format code with black.
There are no other code changes then just formatting of the code. I split up configuration and formatting into two different commits so we can still have a functioning blame.
Therefore PLEASE no squash commit on this PR when merging.
Issue which are not directly related to black I will follow up with other PRs:
Checklist
CHANGELOG.md
updated (only for user relevant changes)AUTHORS