Skip to content

Correctly document JSON API ids as string #824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 4, 2020
Merged

Correctly document JSON API ids as string #824

merged 1 commit into from
Sep 4, 2020

Conversation

sliverc
Copy link
Member

@sliverc sliverc commented Sep 4, 2020

Fixes #818

Description of the Change

Correctly document JSON API ids as string

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

@sliverc
Fixes django-json-api#818
bdf129e 
Correctly document JSON API ids as string
@sliverc sliverc requested a review from n2ygk September 4, 2020 20:47
@sliverc sliverc changed the title Fixes #818 Correctly document JSON API ids as string Sep 4, 2020
n2ygk
n2ygk approved these changes Sep 4, 2020
View reviewed changes
Copy link
Contributor

@n2ygk n2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sliverc sliverc mentioned this pull request Sep 4, 2020
Closed
@n2ygk n2ygk merged commit 45d4224 into django-json-api:master Sep 4, 2020
@sliverc sliverc deleted the id_string branch September 6, 2020 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n2ygk n2ygk n2ygk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JSON output incorrectly wrapping id in quotes
2 participants
@sliverc @n2ygk