Skip to content

Remove global ignore of serializer warnings #816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 25, 2020

Conversation

sliverc
Copy link
Member

@sliverc sliverc commented Aug 24, 2020

Description of the Change

Deprecation warnings should not be suppressed globally but instead test code be adjusted to new default behavior.

Cleanup of #776

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

@sliverc sliverc requested a review from n2ygk August 24, 2020 19:22
@codecov
Copy link

codecov bot commented Aug 24, 2020

Codecov Report

Merging #816 into master will decrease coverage by 0.44%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #816      +/-   ##
==========================================
- Coverage   97.52%   97.08%   -0.45%     
==========================================
  Files          58       58              
  Lines        3157     3158       +1     
==========================================
- Hits         3079     3066      -13     
- Misses         78       92      +14     
Impacted Files Coverage Δ
example/tests/integration/test_meta.py 100.00% <ø> (ø)
.../tests/integration/test_non_paginated_responses.py 100.00% <ø> (ø)
example/tests/integration/test_pagination.py 100.00% <ø> (ø)
example/tests/test_filters.py 100.00% <ø> (ø)
example/tests/test_views.py 100.00% <ø> (ø)
example/tests/unit/test_default_drf_serializers.py 100.00% <ø> (ø)
example/settings/dev.py 100.00% <100.00%> (ø)
example/tests/test_serializers.py 100.00% <100.00%> (ø)
rest_framework_json_api/renderers.py 83.07% <0.00%> (-4.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8dbe008...d242aad. Read the comment docs.

Copy link
Contributor

@n2ygk n2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

@n2ygk n2ygk merged commit 959aec7 into django-json-api:master Aug 25, 2020
@sliverc sliverc deleted the remove_global_warning_exclude branch December 28, 2021 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants