Skip to content

Add handling of nested errors #815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 25, 2020
Merged

Conversation

sliverc
Copy link
Member

@sliverc sliverc commented Aug 24, 2020

Fixes #438
Fixes #416

Description of the Change

Properly handle nested errors. Especially important for nested serializer structure introduced in #776

Extracted from PR #787

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

@sliverc sliverc requested a review from n2ygk August 24, 2020 19:12
@sliverc sliverc mentioned this pull request Aug 24, 2020
5 tasks
Once we drop support for Python 3.5 we might consider moving
back to syrupy again
@codecov
Copy link

codecov bot commented Aug 25, 2020

Codecov Report

Merging #815 into master will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #815      +/-   ##
==========================================
+ Coverage   97.45%   97.52%   +0.07%     
==========================================
  Files          56       58       +2     
  Lines        3068     3157      +89     
==========================================
+ Hits         2990     3079      +89     
  Misses         78       78              
Impacted Files Coverage Δ
example/tests/test_generic_viewset.py 100.00% <ø> (ø)
example/tests/snapshots/snap_test_errors.py 100.00% <100.00%> (ø)
example/tests/test_errors.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3eaf07c...ee4d13a. Read the comment docs.

Copy link
Contributor

@n2ygk n2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm looking forward to these improved error messages. Thanks for this.

@n2ygk n2ygk merged commit 8dbe008 into django-json-api:master Aug 25, 2020
@sliverc sliverc deleted the handling_error branch December 28, 2021 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exception handling with nested resources
2 participants