Make isort test properly run again within Travis #792
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sliverc
force-pushed
the
isort_issue
branch
2 times, most recently
from
b8b6376 to
24e4953
Compare
Codecov Report
@@ Coverage Diff @@
## master #792 +/- ##
=======================================
Coverage 97.39% 97.39%
=======================================
Files 56 56
Lines 2989 2989
=======================================
Hits 2911 2911
Misses 78 78
Continue to review full report at Codecov.
|
sliverc
force-pushed
the
isort_issue
branch
10 times, most recently
from
729e622 to
70e2f0f
Compare
Travis has `build` in its path name and therefore files got skipped from isort. To avoid this we only skip `build/lib` which is used by bdist command.
sliverc
changed the title
auvipy
approved these changes
May 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Travis has
buildin its path name and therefore files got skipped from isort. To avoid this we only skipbuild/libwhich is used by bdist command.This PR fixes the already invalidly committed imports and cleans up obsolete linting settings.
Checklist
CHANGELOG.mdupdated (only for user relevant changes)AUTHORS