Clear m2m relationships instead of deleting related objects during PATCH #788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohithpr
force-pushed
the
fix-784-relationship-view-patch-endpoint
branch
from
6deae03 to
25a36fa
Compare
Codecov Report
@@ Coverage Diff @@
## master #788 +/- ##
=======================================
Coverage 97.39% 97.39%
=======================================
Files 56 56
Lines 2989 2999 +10
=======================================
+ Hits 2911 2921 +10
Misses 78 78
Continue to review full report at Codecov.
|
rohithpr
changed the title
rohithpr
commented
May 14, 2020
sliverc
requested changes
May 19, 2020
rohithpr
force-pushed
the
fix-784-relationship-view-patch-endpoint
branch
2 times, most recently
from
26ca39a to
6021bd3
Compare
auvipy
approved these changes
Jun 10, 2020
sliverc
changed the title
…hem during PATCH Calling PATCH on an M2M RelationshipView when there were already some relationships was breaking. This was because the related objects were being deleted instead of just clearing the relationship and starting afresh.
sliverc
force-pushed
the
fix-784-relationship-view-patch-endpoint
branch
from
b5ecca9 to
3b6c12d
Compare
sliverc
approved these changes
Jun 13, 2020
|
Thanks for your work! I have only added another test to make sure that #244 now works as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Calling PATCH on an M2M RelationshipView when there were already some relationships was breaking. This was because the related objects were being deleted instead of just clearing the relationship and starting afresh.
Fixes #784
Fixes #244
Manual testing proof:
Checklist
CHANGELOG.mdupdated (only for user relevant changes)AUTHORS