-
Notifications
You must be signed in to change notification settings - Fork 301
Allow repeated filter query parameters #782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #782 +/- ##
==========================================
+ Coverage 97.36% 97.39% +0.02%
==========================================
Files 56 56
Lines 2962 2989 +27
==========================================
+ Hits 2884 2911 +27
Misses 78 78
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good in general. Thanks for working on it. As of my comment let's wait for confirmation form @n2ygk . Besides a changelog entry needs to be added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rebase needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Fixes #718
Description of the Change
Allows repeated filter query parameters like
?filter[authors.id]=1&filter[authors.id]=2
.Checklist
CHANGELOG.md
updated (only for user relevant changes)AUTHORS