Skip to content

Allow repeated filter query parameters #782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 20, 2020
Merged

Conversation

ro70
Copy link
Contributor

@ro70 ro70 commented Apr 20, 2020

Fixes #718

Description of the Change

Allows repeated filter query parameters like ?filter[authors.id]=1&filter[authors.id]=2.

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

@codecov
Copy link

codecov bot commented Apr 20, 2020

Codecov Report

Merging #782 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #782      +/-   ##
==========================================
+ Coverage   97.36%   97.39%   +0.02%     
==========================================
  Files          56       56              
  Lines        2962     2989      +27     
==========================================
+ Hits         2884     2911      +27     
  Misses         78       78              
Impacted Files Coverage Δ
example/tests/test_filters.py 100.00% <100.00%> (ø)
rest_framework_json_api/django_filters/backends.py 100.00% <100.00%> (ø)
rest_framework_json_api/filters.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 276ec14...ee29228. Read the comment docs.

Copy link
Member

@sliverc sliverc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good in general. Thanks for working on it. As of my comment let's wait for confirmation form @n2ygk . Besides a changelog entry needs to be added.

Copy link
Contributor

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rebase needed

@sliverc sliverc changed the title Issue718 Allow repeated filter query parameters May 20, 2020
Copy link
Member

@sliverc sliverc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sliverc sliverc merged commit 9057535 into django-json-api:master May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filtering array query params
5 participants