Enforce conflict response when requested PATCH resource object is unequal to endpoint #763
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 16, 2020 19:27
A server MUST return 409 Conflict when processing a PATCH request in which the resource object’s type and id do not match the server’s endpoint.
Codecov Report
@@ Coverage Diff @@
## master #763 +/- ##
=======================================
Coverage 97.12% 97.12%
=======================================
Files 54 54
Lines 2787 2787
=======================================
Hits 2707 2707
Misses 80 80Continue to review full report at Codecov.
|
auvipy
approved these changes
Jan 17, 2020
sliverc
changed the title
sliverc
requested changes
Jan 20, 2020
There was a problem hiding this comment.
Thanks a lot for this great addition to DJA. I always like to see PRs making DJA follow the JSON API spec more closely.
I have added some comments. Additionally in the body I have also added the pull request template again with the checklist. Could you add yourself to AUTHORS list as well and add a changelog entry?
Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
A server MUST return 409 Conflict when processing a PATCH request in which the resource object’s type and id do not match the server’s endpoint.
Checklist
CHANGELOG.mdupdated (only for user relevant changes)AUTHORS