Skip to content

Feature to format the relation names #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 15, 2015
Merged

Feature to format the relation names #76

merged 3 commits into from
Sep 15, 2015

Conversation

schtibe
Copy link
Contributor

@schtibe schtibe commented Sep 14, 2015

Implemented a new option to be able to format the key names in
relations.

@schtibe schtibe closed this Sep 14, 2015
@jsenecal
Copy link
Member

Why was this closed?

@schtibe
Copy link
Contributor Author

schtibe commented Sep 14, 2015

I messed up my repo. Here it is again.

@schtibe schtibe reopened this Sep 14, 2015
@jerel
Copy link
Member

jerel commented Sep 14, 2015

I just have two points of feedback:

  1. Would it make sense to move inflection.pluralize() inside of format_relation_name so it's not repeated everywhere?
  2. Add a note to this file in the docs that the option exists

Implemented a new option to be able to format the key names in
relations.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@schtibe
Copy link
Contributor Author

schtibe commented Sep 15, 2015

@jerel I guess that would make sense, I changed it.

jerel added a commit that referenced this pull request Sep 15, 2015
Added a feature to format the relation names
@jerel jerel merged commit 0382699 into django-json-api:develop Sep 15, 2015
@jerel
Copy link
Member

jerel commented Sep 15, 2015

Good work, thanks for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants