Skip to content

Bundle dependency PRs on a bi-weekly basis #757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 17, 2020

Conversation

sliverc
Copy link
Member

@sliverc sliverc commented Dec 16, 2019

Currently pyup causes a lot of noise so when looking at the closed
PR the real PRs can be easily overlooked.
As we only have test dependencies simply updating on a bi-weekly basis
should be sufficient.

Description of the Change

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

Currently pyup causes a lot of noise so when looking at the closed
PR the real PRs can be easily overlooked.
As we only have test dependencies simply updating on a bi-weekly basis
should be sufficient.
@sliverc sliverc requested a review from n2ygk December 16, 2019 17:34
@codecov
Copy link

codecov bot commented Dec 16, 2019

Codecov Report

Merging #757 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #757      +/-   ##
==========================================
+ Coverage   97.08%   97.12%   +0.03%     
==========================================
  Files          54       54              
  Lines        2742     2779      +37     
==========================================
+ Hits         2662     2699      +37     
  Misses         80       80
Impacted Files Coverage Δ
rest_framework_json_api/renderers.py 87.05% <ø> (+0.25%) ⬆️
example/api/resources/identity.py 100% <ø> (ø) ⬆️
example/tests/test_model_viewsets.py 100% <ø> (ø) ⬆️
example/tests/test_format_keys.py 100% <ø> (ø) ⬆️
example/tests/test_sideload_resources.py 100% <ø> (ø) ⬆️
rest_framework_json_api/metadata.py 91.66% <100%> (ø) ⬆️
rest_framework_json_api/relations.py 87.31% <100%> (+0.12%) ⬆️
rest_framework_json_api/exceptions.py 84.61% <100%> (ø) ⬆️
example/factories.py 100% <0%> (ø) ⬆️
example/tests/conftest.py 100% <0%> (ø) ⬆️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb26c3a...1c04655. Read the comment docs.

@sliverc sliverc changed the title Bundle PR on a bi-weekly basis Bundle dependency PRs on a bi-weekly basis Dec 26, 2019
@n2ygk
Copy link
Contributor

n2ygk commented Jan 6, 2020

@sliverc Sorry, I just noticed these review requests. I've been busy with work/life imbalance. I'll try to get to these in the next week or so.

Copy link
Contributor

@n2ygk n2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - sorry for the delay in reviewing

@n2ygk n2ygk merged commit e3ae420 into django-json-api:master Jan 17, 2020
@sliverc sliverc deleted the pyup_schedules branch December 28, 2021 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants