Skip to content

Remove all deprecated code #688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 11, 2019
Merged

Conversation

sliverc
Copy link
Member

@sliverc sliverc commented Aug 11, 2019

Fixes #662

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

@sliverc sliverc requested a review from n2ygk August 11, 2019 15:30
@codecov
Copy link

codecov bot commented Aug 11, 2019

Codecov Report

Merging #688 into master will decrease coverage by 0.15%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #688      +/-   ##
==========================================
- Coverage   96.12%   95.96%   -0.16%     
==========================================
  Files          56       54       -2     
  Lines        2866     2728     -138     
==========================================
- Hits         2755     2618     -137     
+ Misses        111      110       -1
Impacted Files Coverage Δ
example/tests/test_parsers.py 100% <ø> (ø) ⬆️
rest_framework_json_api/pagination.py 92.68% <ø> (-2.4%) ⬇️
example/tests/unit/test_renderers.py 100% <ø> (ø) ⬆️
example/tests/unit/test_default_drf_serializers.py 100% <ø> (ø) ⬆️
example/tests/unit/test_utils.py 100% <ø> (ø) ⬆️
rest_framework_json_api/settings.py 100% <ø> (ø) ⬆️
example/tests/unit/test_pagination.py 100% <ø> (ø) ⬆️
rest_framework_json_api/parsers.py 97.1% <100%> (ø) ⬆️
rest_framework_json_api/renderers.py 86.79% <100%> (ø) ⬆️
example/api/resources/identity.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7efd877...4de86b4. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Aug 11, 2019

Codecov Report

Merging #688 into master will decrease coverage by 0.15%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #688      +/-   ##
==========================================
- Coverage   96.12%   95.96%   -0.16%     
==========================================
  Files          56       54       -2     
  Lines        2866     2728     -138     
==========================================
- Hits         2755     2618     -137     
+ Misses        111      110       -1
Impacted Files Coverage Δ
example/tests/test_parsers.py 100% <ø> (ø) ⬆️
rest_framework_json_api/pagination.py 92.68% <ø> (-2.4%) ⬇️
example/tests/unit/test_renderers.py 100% <ø> (ø) ⬆️
example/tests/unit/test_default_drf_serializers.py 100% <ø> (ø) ⬆️
example/tests/unit/test_utils.py 100% <ø> (ø) ⬆️
rest_framework_json_api/settings.py 100% <ø> (ø) ⬆️
example/tests/unit/test_pagination.py 100% <ø> (ø) ⬆️
rest_framework_json_api/parsers.py 97.1% <100%> (ø) ⬆️
rest_framework_json_api/renderers.py 86.79% <100%> (ø) ⬆️
example/api/resources/identity.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7efd877...4de86b4. Read the comment docs.

Copy link
Contributor

@n2ygk n2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sliverc Thanks for taking out the trash!

@n2ygk n2ygk merged commit 643e402 into django-json-api:master Aug 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleaning up code for release 3.0.0
2 participants