Skip to content

django-filter>=2.1 #656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 11, 2019
Merged

django-filter>=2.1 #656

merged 3 commits into from
Jun 11, 2019

Conversation

n2ygk
Copy link
Contributor

@n2ygk n2ygk commented Jun 7, 2019

Follows #561

Description of the Change

Updates tox/travis to use django-filter>=2.1

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

@n2ygk n2ygk requested a review from sliverc June 7, 2019 13:55
@n2ygk
Copy link
Contributor Author

n2ygk commented Jun 7, 2019

@sliverc I'm not sure it's strictly necessary to do this but figured perhaps the test requirements should be consistent with what's in requirements-development.txt.

@codecov
Copy link

codecov bot commented Jun 9, 2019

Codecov Report

Merging #656 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #656   +/-   ##
=======================================
  Coverage   96.15%   96.15%           
=======================================
  Files          57       57           
  Lines        2889     2889           
=======================================
  Hits         2778     2778           
  Misses        111      111

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1be895...e9f3d62. Read the comment docs.

@sliverc
Copy link
Member

sliverc commented Jun 11, 2019

It doesn't really make a difference in terms of what deps are installed but doesn't really hurt either. Hence merging.

@sliverc sliverc merged commit 1a09191 into django-json-api:master Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants