Remove not always supported auto select_related
#651
Conversation
Codecov Report
@@ Coverage Diff @@
## master #651 +/- ##
=======================================
Coverage 96.13% 96.13%
=======================================
Files 56 56
Lines 2869 2869
=======================================
Hits 2758 2758
Misses 111 111
Continue to review full report at Codecov.
|
|
Probably we want Polymorpihc stuff make using custom select/prefetch related config, but not removing |
|
First I thought it would be a good idea to automatically choose So all in all also for backwards compatibility it is better to remove it. And in some case if someone has a data structure which is faster with |
Polymorphic models do not always support `select_related` as of https://django-polymorphic.readthedocs.io/en/stable/advanced.html?highlight=select_related#about-queryset-methods and might actually be slower in some cases as explained in https://django-rest-framework-json-api.readthedocs.io/en/stable/usage.html?highlight=usage#performance-improvements Hence reverting change of AutoPreloadMixin as it has not been released yet.
sliverc
force-pushed
the
remove_auto_select_related
branch
from
bd8ed3f to
512846e
Compare
There was a problem hiding this comment.
Sorry I forgot this was assigned to me. I'm a little iffy on this as I've no experience using the polymorphic code, but if @sliverc and @Anton-Shutik are OK with this (as indicated) then I approve.
Addresses testing issue in #643
Description of the Change
Polymorphic models do not always support select_related and might actually be slower.
Hence reverting change of
AutoPreloadMixinas it has not been released yet.Checklist
CHANGELOG.mdupdated (only for user relevant changes)AUTHORS