Skip to content

tox flake8-isort exclude env and .venv #645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 31, 2019

Conversation

n2ygk
Copy link
Contributor

@n2ygk n2ygk commented May 31, 2019

Description of the Change

Updates setup.cfg to ignore the .venv/ or env/ directories as was already the case in .gitconfig.
This allows having a local virtualenv that tox -e flake8 doesn't scan.

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

@n2ygk n2ygk requested a review from sliverc May 31, 2019 17:02
@codecov
Copy link

codecov bot commented May 31, 2019

Codecov Report

Merging #645 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #645   +/-   ##
=======================================
  Coverage   96.16%   96.16%           
=======================================
  Files          56       56           
  Lines        2870     2870           
=======================================
  Hits         2760     2760           
  Misses        110      110
Impacted Files Coverage Δ
rest_framework_json_api/django_filters/backends.py 100% <ø> (ø) ⬆️
example/tests/test_views.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bb123c...90230cf. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented May 31, 2019

Codecov Report

Merging #645 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #645   +/-   ##
=======================================
  Coverage   96.16%   96.16%           
=======================================
  Files          56       56           
  Lines        2870     2870           
=======================================
  Hits         2760     2760           
  Misses        110      110
Impacted Files Coverage Δ
rest_framework_json_api/django_filters/backends.py 100% <ø> (ø) ⬆️
example/tests/test_views.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bb123c...90230cf. Read the comment docs.

Copy link
Member

@sliverc sliverc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sliverc sliverc merged commit c392793 into django-json-api:master May 31, 2019
@n2ygk n2ygk deleted the tox_flake8_isort_exclude_venv branch June 9, 2019 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants