Skip to content

Add Django 2.2 support #640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 24, 2019
Merged

Add Django 2.2 support #640

merged 2 commits into from
May 24, 2019

Conversation

sliverc
Copy link
Member

@sliverc sliverc commented May 24, 2019

Description of the Change

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

@codecov
Copy link

codecov bot commented May 24, 2019 •
edited
Loading

Codecov Report

Merging #640 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #640   +/-   ##
=======================================
  Coverage   96.16%   96.16%           
=======================================
  Files          56       56           
  Lines        2866     2866           
=======================================
  Hits         2756     2756           
  Misses        110      110

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c77fe0f...77176f3. Read the comment docs.

@sliverc sliverc requested a review from n2ygk May 24, 2019 16:04
@sliverc sliverc mentioned this pull request May 24, 2019
Closed
n2ygk
n2ygk approved these changes May 24, 2019
View reviewed changes
Copy link
Contributor

@n2ygk n2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@n2ygk n2ygk merged commit 2109c52 into django-json-api:master May 24, 2019
n2ygk
n2ygk reviewed May 24, 2019
View reviewed changes
Copy link
Contributor

@n2ygk n2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sliverc woops I think I merged this too soon. Don't you need to add stuff to tox.ini envlist as well?

@sliverc sliverc deleted the dj22 branch May 24, 2019 17:58
@sliverc
Copy link
Member Author

sliverc commented May 24, 2019

@n2ygk Indeed. I will follow up with another PR>

@sliverc sliverc mentioned this pull request May 24, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n2ygk n2ygk n2ygk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sliverc @n2ygk