-
Notifications
You must be signed in to change notification settings - Fork 301
Fix deprecation warnings regarding collections.abc #624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deprecation warnings regarding collections.abc #624
Conversation
Codecov Report
@@ Coverage Diff @@
## master #624 +/- ##
==========================================
+ Coverage 95.65% 95.66% +0.01%
==========================================
Files 55 55
Lines 2856 2863 +7
==========================================
+ Hits 2732 2739 +7
Misses 124 124
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #624 +/- ##
==========================================
+ Coverage 95.65% 95.66% +<.01%
==========================================
Files 55 56 +1
Lines 2856 2861 +5
==========================================
+ Hits 2732 2737 +5
Misses 124 124
Continue to review full report at Codecov.
|
Thanks for working on this. I would prefer if we could move those imports into a compat.py as DRF does This way we will find the deprecation fixes again in the future in case we can delete it again. I think a CHANGELOG entry will also be needed below Fixed as a deprecation warning fix is user facing e.g. for users who turn deprecation warnings into errors. |
Currently there is no |
yes best create one. This way we follow how DRF handles such issues. |
I have modified my PR to use compat.py and also added a note on Changelog. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks!
Fixes #613
Description of the Change
DeprecationWarning
over usage ofcollections
instead ofcollections.abc
Checklist
CHANGELOG.md
updated (only for user relevant changes)AUTHORS
The PR doesn't seem to have user impacting changes. Let me know if these need to be updated.
Thanks.