Skip to content

DjangoFilterBackend.get_filterset_kwargs doesn't modify data dict while iterating #580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 2, 2019
Merged

DjangoFilterBackend.get_filterset_kwargs doesn't modify data dict while iterating #580

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ffc2c1b
switched DjangoFilterBackend.get_filterset_kwargs to populate new dat…
Feb 24, 2019
b478f06
Made data return with all params, not just filter
Feb 24, 2019
3538d76
Added test for skipping filters if there are many query params
Feb 25, 2019
9752ff3
Merge remote-tracking branch 'upstream/master' into feature/fix-skipp…
Feb 25, 2019
598dddb
Updated CHANGELOG
Feb 25, 2019
9f3bc0b
Update CHANGELOG.md
sliverc Mar 1, 2019
8eca777
Merge branch 'master' into feature/fix-skipped-filter-param
sliverc Mar 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions rest_framework_json_api/django_filters/backends.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
from django_filters.rest_framework import DjangoFilterBackend
from rest_framework.exceptions import ValidationError
from rest_framework.settings import api_settings

from rest_framework_json_api.utils import format_value


Expand Down Expand Up @@ -102,7 +101,7 @@ def get_filterset_kwargs(self, request, queryset, view):
filter_keys = []
# rewrite filter[field] query params to make DjangoFilterBackend work.
data = request.query_params.copy()
for qp, val in data.items():
for qp, val in request.query_params.items():
m = self.filter_regex.match(qp)
if m and (not m.groupdict()['assoc'] or
m.groupdict()['ldelim'] != '[' or m.groupdict()['rdelim'] != ']'):
Expand Down