Skip to content

Don't render write only relations #522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 29, 2018

Conversation

winged
Copy link
Contributor

@winged winged commented Nov 28, 2018

Fixes #421

Description of the Change

Don't output key for write only relations.

This builds on top of #421 and adds the requested test cases.

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • changelog entry added to CHANGELOG.md
  • author name in AUTHORS

@sliverc sliverc self-requested a review November 28, 2018 16:09
Copy link
Member

@sliverc sliverc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thanks. I have added the checklist again on the PR description.

Could you add yourself to AUTHORS and add a changelog entry as well? It also seems a rebase to current master is needed.

Once this is done this can be merged.

peakwinter and others added 3 commits November 29, 2018 09:17
This makes `render_dummy_test_serialized_view()` a bit more versatile,
as it can be used with different viewsets that have serializers other
than `DummyTestSerializer`.
@winged winged force-pushed the fix/write_only_relations branch from 0147a24 to 5da257f Compare November 29, 2018 08:18
@winged winged force-pushed the fix/write_only_relations branch from 5da257f to 3c1767c Compare November 29, 2018 08:20
@sliverc sliverc changed the title Fix/write only relations Don't render write only relations Nov 29, 2018
@sliverc sliverc merged commit 9208b4d into django-json-api:master Nov 29, 2018
@winged winged deleted the fix/write_only_relations branch November 29, 2018 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants