Fixes #489: PKOnlyObject object has no attribute for retrieve_related of a to-one relationship
#513
+1,153
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…`retrieve_related` of a to-one relationship
|
I have taken some time to read into this issue. Monkey patching is always risky as it might cause side effects. I have written a bit of a different patch at #517 which fixes the issue without monkey patching and also uses the existing tests environment to reproduce the issue. Best have a look there. Closing this PR in favor of #517 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #489
Description of the Change
Fixes incorrect PKOnly optimization for a toOne relationship by overriding
use_pk_only_optimizationinRelatedMixin.get_related_instance.This behavior is selectable by overriding the
RelatedMixin.override_pk_only_optimizationfeature flag which is used to demonstrate the bug in the test case code. After some time with no issues identified, we should consider removing this feature flag.See #492 for further discussion.
Checklist
CHANGELOG.mdAUTHORS