Skip to content

WIP: workaround "'PKOnlyObject' object has no attribute" error for toOne related #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 25 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
e858bb4
workaround "'PKOnlyObject' object has no attribute" error
n2ygk Oct 11, 2018
0880575
add new Course and Term models to reproduce "'PKOnlyObject' object ha…
n2ygk Oct 13, 2018
a948813
use RelatedMixin.override_pk_only_optimization=True to prevent Attrib…
n2ygk Oct 13, 2018
8c78bc7
default override_pk_only_optimization True
n2ygk Oct 13, 2018
d645f81
tox, flake8, isort, make test exception a passing test
n2ygk Oct 13, 2018
5dc8e45
Merge remote-tracking branch 'upstream/master' into related_disable_p…
n2ygk Oct 13, 2018
f02c7c4
Merge remote-tracking branch 'upstream/master' into related_disable_p…
n2ygk Oct 15, 2018
d0debda
add drf39 and drfmaster tests (#498)
n2ygk Oct 23, 2018
00fb5dc
Adjust to new flake8 3.6.0 version (#501)
sliverc Oct 24, 2018
b3eed32
Avoid patch on `RelationshipView` deleting relationship instance when…
Alig1493 Oct 25, 2018
860a096
Use pytest instead of py.test (#502)
sliverc Oct 25, 2018
a4d063f
Use pyupio to manage development dependencies (#503)
sliverc Oct 25, 2018
56b5fd7
Initial Update (#506)
pyup-bot Oct 26, 2018
1ce84f8
Adjust depreaction warning to state to move to JSON_API_FORMAT_FIELD_…
sliverc Oct 26, 2018
7d14537
Update pytest from 3.9.2 to 3.9.3 (#508)
pyup-bot Oct 29, 2018
274cb79
Update sphinx from 1.8.1 to 1.8.2 (#511)
pyup-bot Nov 11, 2018
0f09a6e
Update pytest-factoryboy from 2.0.1 to 2.0.2 (#510)
pyup-bot Nov 11, 2018
7cdcff7
Update pytest from 3.9.3 to 3.10.1 (#512)
pyup-bot Nov 12, 2018
7ec8e42
Test support of DRF HyperlinkedIdentityField (#497)
Alig1493 Nov 12, 2018
4d7a655
workaround "'PKOnlyObject' object has no attribute" error
n2ygk Oct 11, 2018
a3ac0d2
add new Course and Term models to reproduce "'PKOnlyObject' object ha…
n2ygk Oct 13, 2018
509edfa
use RelatedMixin.override_pk_only_optimization=True to prevent Attrib…
n2ygk Oct 13, 2018
875b56b
default override_pk_only_optimization True
n2ygk Oct 13, 2018
2262aa6
tox, flake8, isort, make test exception a passing test
n2ygk Oct 13, 2018
dc5d860
Merge branch 'related_disable_pk_only' of github.com:n2ygk/django-res…
n2ygk Nov 12, 2018
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .pyup.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
search: False
requirements:
- requirements-development.txt:
update: all
pin: True
50 changes: 49 additions & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
@@ -1,8 +1,17 @@
language: python
sudo: false
sudo: required
cache: pip
# Favor explicit over implicit and use an explicit build matrix.
matrix:
allow_failures:
- env: TOXENV=py34-df20-django20-drfmaster
- env: TOXENV=py35-df20-django20-drfmaster
- env: TOXENV=py36-df20-django20-drfmaster
- env: TOXENV=py37-df20-django20-drfmaster
- env: TOXENV=py35-df20-django21-drfmaster
- env: TOXENV=py36-df20-django21-drfmaster
- env: TOXENV=py37-df20-django21-drfmaster

include:
- python: 3.6
env: TOXENV=flake8
Expand All @@ -13,6 +22,8 @@ matrix:
env: TOXENV=py27-df11-django111-drf37
- python: 2.7
env: TOXENV=py27-df11-django111-drf38
- python: 2.7
env: TOXENV=py27-df11-django111-drf39

- python: 3.4
env: TOXENV=py34-df20-django111-drf36
Expand All @@ -24,6 +35,10 @@ matrix:
env: TOXENV=py34-df20-django20-drf37
- python: 3.4
env: TOXENV=py34-df20-django20-drf38
- python: 3.4
env: TOXENV=py34-df20-django20-drf39
- python: 3.4
env: TOXENV=py34-df20-django20-drfmaster

- python: 3.5
env: TOXENV=py35-df20-django111-drf36
Expand All @@ -35,6 +50,14 @@ matrix:
env: TOXENV=py35-df20-django20-drf37
- python: 3.5
env: TOXENV=py35-df20-django20-drf38
- python: 3.5
env: TOXENV=py35-df20-django20-drf39
- python: 3.5
env: TOXENV=py35-df20-django20-drfmaster
- python: 3.5
env: TOXENV=py35-df20-django21-drf39
- python: 3.5
env: TOXENV=py35-df20-django21-drfmaster

- python: 3.6
env: TOXENV=py36-df20-django111-drf36
Expand All @@ -46,6 +69,31 @@ matrix:
env: TOXENV=py36-df20-django20-drf37
- python: 3.6
env: TOXENV=py36-df20-django20-drf38
- python: 3.6
env: TOXENV=py36-df20-django20-drf39
- python: 3.6
env: TOXENV=py36-df20-django20-drfmaster
- python: 3.6
env: TOXENV=py36-df20-django21-drf39
- python: 3.6
env: TOXENV=py36-df20-django21-drfmaster

- python: 3.7
dist: xenial
sudo: required
env: TOXENV=py37-df20-django20-drf39
- python: 3.7
dist: xenial
sudo: required
env: TOXENV=py37-df20-django20-drfmaster
- python: 3.7
dist: xenial
sudo: required
env: TOXENV=py37-df20-django21-drf39
- python: 3.7
dist: xenial
sudo: required
env: TOXENV=py37-df20-django21-drfmaster
install:
- pip install tox
script:
Expand Down
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,17 @@ any parts of the framework not mentioned in the documentation should generally b

### Added

* Add support for Django 2.1, DRF 3.9 and Python 3.7. Please note:
- Django >= 2.1 is not supported with Python < 3.5.

### Deprecated

### Changed

### Fixed

* Pass context from `PolymorphicModelSerializer` to child serializers to support fields which require a `request` context such as `url`.
* Avoid patch on `RelationshipView` deleting relationship instance when constraint would allow null ([#242](https://github.com/django-json-api/django-rest-framework-json-api/issues/242))


## [2.6.0] - 2018-09-20
Expand Down
16 changes: 11 additions & 5 deletions README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -87,9 +87,9 @@ As a Django REST Framework JSON API (short DJA) we are trying to address followi
Requirements
------------

1. Python (2.7, 3.4, 3.5, 3.6)
2. Django (1.11, 2.0)
3. Django REST Framework (3.6, 3.7, 3.8)
1. Python (2.7, 3.4, 3.5, 3.6, 3.7)
2. Django (1.11, 2.0, 2.1)
3. Django REST Framework (3.6, 3.7, 3.8, 3.9)

------------
Installation
Expand All @@ -116,12 +116,18 @@ From Source
Running the example app
^^^^^^^^^^^^^^^^^^^^^^^

It is recommended to create a virtualenv for testing. Assuming it is already
installed and activated:

::

$ git clone https://github.com/django-json-api/django-rest-framework-json-api.git
$ cd django-rest-framework-json-api
$ pip install -r example/requirements.txt
$ pip install -e .
$ django-admin.py runserver --settings=example.settings
$ django-admin migrate --settings=example.settings
$ django-admin loaddata drf_example --settings=example.settings
$ django-admin runserver --settings=example.settings

Browse to http://localhost:8000

Expand All @@ -136,7 +142,7 @@ installed and activated:

$ pip install -r requirements-development.txt
$ flake8
$ py.test
$ pytest

-----
Usage
Expand Down
6 changes: 3 additions & 3 deletions docs/getting-started.md
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,9 @@ like the following:

## Requirements

1. Python (2.7, 3.4, 3.5, 3.6)
2. Django (1.11, 2.0)
3. Django REST Framework (3.6, 3.7, 3.8)
1. Python (2.7, 3.4, 3.5, 3.6, 3.7)
2. Django (1.11, 2.0, 2.1)
3. Django REST Framework (3.6, 3.7, 3.8, 3.9)

## Installation

Expand Down
Loading