Skip to content

deprecate MultipleIDMixin #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 19, 2018
Merged

deprecate MultipleIDMixin #482

merged 2 commits into from
Sep 19, 2018

Conversation

n2ygk
Copy link
Contributor

@n2ygk n2ygk commented Sep 18, 2018

Fixes #480

Description of the Change

Deprecates MultipleIDMixin now that there's a JSON:API spec-compliant version (#466) using
filter[id.in]= instead of ids[]=. This will require client changes to change the query param.

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • changelog entry added to CHANGELOG.md
  • author name in AUTHORS

@n2ygk n2ygk added this to the 2.6.0 milestone Sep 18, 2018
@n2ygk n2ygk requested a review from sliverc September 18, 2018 14:39
@n2ygk n2ygk changed the title Deprecate multiple id mixin Deprecate MultipleIDMixin Sep 18, 2018
@n2ygk n2ygk changed the title Deprecate MultipleIDMixin deprecate MultipleIDMixin Sep 18, 2018
@sliverc sliverc merged commit 760845a into django-json-api:master Sep 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sliverc sliverc sliverc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@n2ygk @sliverc