Skip to content

Fix import NoReverseMatch #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .coverage

Large diffs are not rendered by default.

19 changes: 13 additions & 6 deletions example/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ class Meta:
class Author(BaseModel):
name = models.CharField(max_length=50)
email = models.EmailField()
type = models.ForeignKey(AuthorType, null=True)
type = models.ForeignKey(AuthorType, null=True, on_delete=models.CASCADE)

def __str__(self):
return self.name
Expand All @@ -71,7 +71,9 @@ class Meta:

@python_2_unicode_compatible
class AuthorBio(BaseModel):
author = models.OneToOneField(Author, related_name='bio')
author = models.OneToOneField(
Author, related_name='bio', on_delete=models.CASCADE
)
body = models.TextField()

def __str__(self):
Expand All @@ -83,7 +85,7 @@ class Meta:

@python_2_unicode_compatible
class Entry(BaseModel):
blog = models.ForeignKey(Blog)
blog = models.ForeignKey(Blog, on_delete=models.CASCADE)
headline = models.CharField(max_length=255)
body_text = models.TextField(null=True)
pub_date = models.DateField(null=True)
Expand All @@ -103,12 +105,15 @@ class Meta:

@python_2_unicode_compatible
class Comment(BaseModel):
entry = models.ForeignKey(Entry, related_name='comments')
entry = models.ForeignKey(
Entry, related_name='comments', on_delete=models.CASCADE
)
body = models.TextField()
author = models.ForeignKey(
Author,
null=True,
blank=True
blank=True,
on_delete=models.CASCADE
)

def __str__(self):
Expand All @@ -133,7 +138,9 @@ class ResearchProject(Project):
@python_2_unicode_compatible
class Company(models.Model):
name = models.CharField(max_length=100)
current_project = models.ForeignKey(Project, related_name='companies')
current_project = models.ForeignKey(
Project, related_name='companies', on_delete=models.CASCADE
)
future_projects = models.ManyToManyField(Project)

def __str__(self):
Expand Down
7 changes: 6 additions & 1 deletion example/tests/integration/test_includes.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
import pytest
from django.core.urlresolvers import reverse
import django

if django.VERSION >= (1, 10):
from django.urls import reverse
else:
from django.core.urlresolvers import reverse

from example.tests.utils import load_json

Expand Down
7 changes: 6 additions & 1 deletion example/tests/integration/test_meta.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,12 @@
from datetime import datetime

import pytest
from django.core.urlresolvers import reverse
import django

if django.VERSION >= (1, 10):
from django.urls import reverse
else:
from django.core.urlresolvers import reverse

from example.tests.utils import load_json

Expand Down
8 changes: 7 additions & 1 deletion example/tests/integration/test_model_resource_name.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,13 @@
from copy import deepcopy

import pytest
from django.core.urlresolvers import reverse
import django

if django.VERSION >= (1, 10):
from django.urls import reverse
else:
from django.core.urlresolvers import reverse

from rest_framework import status

from example import models, serializers, views
Expand Down
7 changes: 6 additions & 1 deletion example/tests/integration/test_non_paginated_responses.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
import pytest
from django.core.urlresolvers import reverse
import django

if django.VERSION >= (1, 10):
from django.urls import reverse
else:
from django.core.urlresolvers import reverse

from rest_framework_json_api.pagination import PageNumberPagination

Expand Down
7 changes: 6 additions & 1 deletion example/tests/integration/test_pagination.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
import pytest
from django.core.urlresolvers import reverse
import django

if django.VERSION >= (1, 10):
from django.urls import reverse
else:
from django.core.urlresolvers import reverse

from example.tests.utils import load_json

Expand Down
7 changes: 6 additions & 1 deletion example/tests/integration/test_polymorphism.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,12 @@
import random

import pytest
from django.core.urlresolvers import reverse
import django

if django.VERSION >= (1, 10):
from django.urls import reverse
else:
from django.core.urlresolvers import reverse

from example.tests.utils import load_json

Expand Down
7 changes: 6 additions & 1 deletion example/tests/integration/test_sparse_fieldsets.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
import pytest
from django.core.urlresolvers import reverse
import django

if django.VERSION >= (1, 10):
from django.urls import reverse
else:
from django.core.urlresolvers import reverse

pytestmark = pytest.mark.django_db

Expand Down
7 changes: 6 additions & 1 deletion example/tests/test_format_keys.py
Original file line number Diff line number Diff line change
@@ -1,10 +1,15 @@
import django
from django.contrib.auth import get_user_model
from django.core.urlresolvers import reverse
from django.utils import encoding

from example.tests import TestBase
from example.tests.utils import load_json

if django.VERSION >= (1, 10):
from django.urls import reverse
else:
from django.core.urlresolvers import reverse


class FormatKeysSetTests(TestBase):
"""
Expand Down
6 changes: 5 additions & 1 deletion example/tests/test_generic_validation.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
from django.core.urlresolvers import reverse
import django
if django.VERSION >= (1, 10):
from django.urls import reverse
else:
from django.core.urlresolvers import reverse

from example.tests import TestBase
from example.tests.utils import load_json
Expand Down
7 changes: 6 additions & 1 deletion example/tests/test_generic_viewset.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
import django
from django.conf import settings
from django.core.urlresolvers import reverse

if django.VERSION >= (1, 10):
from django.urls import reverse
else:
from django.core.urlresolvers import reverse

from example.tests import TestBase
from example.tests.utils import load_json
Expand Down
7 changes: 6 additions & 1 deletion example/tests/test_model_viewsets.py
Original file line number Diff line number Diff line change
@@ -1,9 +1,14 @@
import pytest
import django
from django.conf import settings
from django.contrib.auth import get_user_model
from django.core.urlresolvers import reverse
from django.utils import encoding

if django.VERSION >= (1, 10):
from django.urls import reverse
else:
from django.core.urlresolvers import reverse

from example.tests import TestBase
from example.tests.utils import dump_json, load_json

Expand Down
7 changes: 6 additions & 1 deletion example/tests/test_multiple_id_mixin.py
Original file line number Diff line number Diff line change
@@ -1,8 +1,13 @@
import json

from django.core.urlresolvers import reverse
import django
from django.utils import encoding

if django.VERSION >= (1, 10):
from django.urls import reverse
else:
from django.core.urlresolvers import reverse

from example.tests import TestBase


Expand Down
7 changes: 6 additions & 1 deletion example/tests/test_serializers.py
Original file line number Diff line number Diff line change
@@ -1,8 +1,13 @@
import pytest
from django.core.urlresolvers import reverse
import django
from django.test import TestCase
from django.utils import timezone

if django.VERSION >= (1, 10):
from django.urls import reverse
else:
from django.core.urlresolvers import reverse

from rest_framework_json_api.serializers import ResourceIdentifierObjectSerializer
from rest_framework_json_api.utils import format_resource_type

Expand Down
7 changes: 6 additions & 1 deletion example/tests/test_sideload_resources.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,14 @@
"""
import json

from django.core.urlresolvers import reverse
import django
from django.utils import encoding

if django.VERSION >= (1, 10):
from django.urls import reverse
else:
from django.core.urlresolvers import reverse

from example.tests import TestBase


Expand Down
9 changes: 7 additions & 2 deletions example/tests/test_views.py
Original file line number Diff line number Diff line change
@@ -1,10 +1,15 @@
import json

import django
from django.test import RequestFactory
from django.utils import timezone
from rest_framework.reverse import reverse
from rest_framework.test import APITestCase, force_authenticate

if django.VERSION >= (1, 10):
from django.urls import reverse
else:
from django.core.urlresolvers import reverse

from rest_framework.test import APITestCase, force_authenticate
from rest_framework_json_api.utils import format_resource_type

from . import TestBase
Expand Down
7 changes: 6 additions & 1 deletion rest_framework_json_api/relations.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@

import inflection
import six
import django
from django.core.exceptions import ImproperlyConfigured
from django.core.urlresolvers import NoReverseMatch
from django.utils.translation import ugettext_lazy as _
from rest_framework.fields import MISSING_ERROR_MESSAGE
from rest_framework.relations import MANY_RELATION_KWARGS, PrimaryKeyRelatedField
Expand All @@ -21,6 +21,11 @@
get_resource_type_from_serializer
)

if django.VERSION >= (1, 10):
from django.urls import NoReverseMatch
else:
from django.core.urlresolvers import NoReverseMatch

LINKS_PARAMS = [
'self_link_view_name',
'related_link_view_name',
Expand Down