Skip to content

Add isort to CI process #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 26, 2017
Merged

Conversation

mblayman
Copy link
Collaborator

@mblayman mblayman commented Jun 26, 2017

This branch adds isort to the CI process so that import ordering issues can be left to a tool. It also does an initial run through on the code so that everything respects the isort settings.

Fixes #344

@mblayman
Copy link
Collaborator Author

This is an annoying dev vs CI issue. I'll keep poking on this later, but the tl;dr is that isort works locally in my dev env, but then fails to consider django-polymorphic and pytest_factoryboy as third party packages on Travis.

@codecov-io
Copy link

codecov-io commented Jun 26, 2017

Codecov Report

Merging #360 into develop will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #360      +/-   ##
===========================================
- Coverage    92.82%   92.81%   -0.01%     
===========================================
  Files           51       51              
  Lines         2647     2644       -3     
===========================================
- Hits          2457     2454       -3     
  Misses         190      190
Impacted Files Coverage Δ
example/tests/test_generic_validation.py 100% <ø> (ø) ⬆️
example/tests/conftest.py 100% <ø> (ø) ⬆️
example/tests/unit/test_pagination.py 100% <ø> (ø) ⬆️
example/views.py 90.56% <100%> (ø) ⬆️
rest_framework_json_api/exceptions.py 84% <100%> (-0.62%) ⬇️
example/tests/unit/test_utils.py 100% <100%> (ø) ⬆️
example/tests/test_views.py 100% <100%> (ø) ⬆️
rest_framework_json_api/views.py 95.51% <100%> (ø) ⬆️
example/tests/test_serializers.py 100% <100%> (ø) ⬆️
example/tests/integration/test_sparse_fieldsets.py 100% <100%> (ø) ⬆️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4970f93...0de68e6. Read the comment docs.

@mblayman mblayman merged commit a62c0a5 into django-json-api:develop Jun 26, 2017
@mblayman mblayman deleted the ci-isort branch June 26, 2017 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants