Skip to content

respect custom related_link_url_kwarg #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from Jun 28, 2017
Merged

respect custom related_link_url_kwarg #359

merged 1 commit into from Jun 28, 2017

Conversation

ghost
Copy link

@ghost ghost commented Jun 21, 2017

fix #358

@codecov-io
Copy link

codecov-io commented Jun 21, 2017

Codecov Report

Merging #359 into develop will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #359   +/-   ##
========================================
  Coverage    92.81%   92.81%           
========================================
  Files           51       51           
  Lines         2644     2644           
========================================
  Hits          2454     2454           
  Misses         190      190
Impacted Files Coverage Δ
rest_framework_json_api/renderers.py 86.92% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a62c0a5...ef3e61f. Read the comment docs.

@mblayman
Copy link
Collaborator

Hi, @Ola-t! Thanks for the contribution. The fix looks good to me. 👍

As this is a community run project, we'd like for every contributor to get credit for their work. Could you add your name to the AUTHORS file (it's alphabetical by first name)? I'm happy to merge the work after that.

@Darkheir
Copy link
Contributor

Darkheir commented Jun 28, 2017

This doesn't fix the problem in the many-many relations.

The folowing line should also be corrected :
https://github.com/ola-t/django-rest-framework-json-api/blob/ef3e61f55e9a89b30e5c6147eeafe92145a82d27/rest_framework_json_api/renderers.py#L193

To be

field_links = field.child_relation.get_links(resource_instance, field.child_relation.related_link_lookup_field)

If needed I could create a separate pull request.

@mblayman
Copy link
Collaborator

@Darkheir, thanks for thinking about that case. If you could make a separate pull request, that would probably be the quickest fix for the many-to-many issue. I'm going to go ahead and merge this one.

@mblayman mblayman merged commit 69d899f into django-json-api:develop Jun 28, 2017
@ghost ghost deleted the custom_related_link_url_kwarg branch June 28, 2017 14:52
@ghost
Copy link
Author

ghost commented Jun 30, 2017

When are you planning to release these bug fixes?

@mblayman
Copy link
Collaborator

I would like to see a release soon. I either need to get upload permission to PyPI to do it or @jerel will need to release the package. Either action will require some input from him that's out of my control.

Before the release, I think the demo site needs to be fixed so #356 is a blocker that should be addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants