Skip to content

Fix tests to work with DRF 3.6.3. #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 17, 2017

Conversation

mblayman
Copy link
Collaborator

Fixes #350

mblayman added 2 commits May 17, 2017 08:48
This test checked a condition that created a RuntimeError in the past.
In this newer version of DRF, the field is not included so the key
should be ignored when not present.
@mblayman mblayman merged commit a12d98d into django-json-api:develop May 17, 2017
@mblayman mblayman deleted the drf-3.6.3-test-breakage branch May 17, 2017 13:50
@codecov-io
Copy link

codecov-io commented May 17, 2017

Codecov Report

Merging #351 into develop will increase coverage by 0.57%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #351      +/-   ##
===========================================
+ Coverage    76.52%   77.09%   +0.57%     
===========================================
  Files           50       50              
  Lines         5937     6026      +89     
===========================================
+ Hits          4543     4646     +103     
+ Misses        1394     1380      -14
Impacted Files Coverage Δ
rest_framework_json_api/serializers.py 88.46% <100%> (ø) ⬆️
example/serializers.py 100% <100%> (ø) ⬆️
rest_framework_json_api/pagination.py 54.81% <0%> (+1.72%) ⬆️
rest_framework_json_api/relations.py 90.15% <0%> (+2.62%) ⬆️
rest_framework_json_api/renderers.py 64.07% <0%> (+2.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 485953f...ff98a39. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants