-
Notifications
You must be signed in to change notification settings - Fork 301
Implemented py.test runner in setup.py #268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented py.test runner in setup.py #268
Conversation
Current coverage is 90.37% (diff: 100%)
|
@scottfisk what do you think of these changes? I'm happy with merging them if you are. |
@@ -1,8 +1,8 @@ | |||
[tox] | |||
envlist = | |||
py{27,33,34}-django17-drf{31,32}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@georgemarshall It looks like python 3.2 wasn't in the environments before here or travis.yml Since one of your suggestions was to remove it, we can probably just leave it out?
We should probably remove any other references to python 3.2 while we are at it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ha, you're right... Must of stayed up later than I should have.
@georgemarshall I do like the coverage reporting as well 👍 @jerel Dropped one comment in re python 3.2 |
Any feedback on Django 1.7 EOL? |
@georgemarshall I was the only one using it last time we did a poll. We am now using 1.9, so I am ok with dropping it. |
c34b489
to
f98591b
Compare
Other highlights:
Suggestions: