SerializerMethodResourceRelatedField with many=True does not show up in included #260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like only one building Travis failed. It looks like the setup failed |
|
Would it be helpful if this was behind a setting so that those with accustomed to the current behavior are not affected? Or is this a bug? I am preferable to the former. |
khornberg
added a commit
to imtapps-dev/django-rest-framework-json-api
that referenced
this pull request
Aug 18, 2016
Adds PR 260 django-json-api#260 This allows a resource related field to be returned with the request instead of having to make multiple requests to get related fields.
|
I would view this as a bug: when a field is specified in |
jerel
added a commit
that referenced
this pull request
Aug 18, 2016
…ub.com/tbartelmess/django-rest-framework-json-api into tbartelmess-fix/include-in-many-related-serializer Closes #260
|
Yeah, after playing with it, I came to the same conclusion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a
SerializerMethodResourceRelatedFieldin a serializer, withmany=Truebeing set, and the request is asking for to include it (via the?include) parameter, the field is not included in the result.This PR adds a test and a fairly hackish fix (by checking is a 'child_relation' is present in the
_kwargsparameter, when the field is evaluated for includes).