Support many=True on related serializer method fields. #223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I reviewed the code, while I cant test on any project I am currently working on, I don't think this should break anything :) |
| @@ -31,7 +31,7 @@ def test_included_data_on_detail(single_entry, client): | |||
|
|
|||
| def test_dynamic_related_data_is_included(single_entry, entry_factory, client): | |||
| entry_factory() | |||
| response = client.get(reverse("entry-detail", kwargs={'pk': single_entry.pk}) + '?include=suggested') | |||
| response = client.get(reverse("entry-detail", kwargs={'pk': single_entry.pk}) + '?include=featured') | |||
There was a problem hiding this comment.
@jerel why was the test changed here? I get a failure when including a SerializerMethodResourceRelatedField, is this intentional?
The failure is 'function' object has no attribute 'parent'
There was a problem hiding this comment.
I am also a bit surprised by this change. However this is a two year old PR and things might have changed as well so maybe not the right place to discuss this.
I guess if you have issues including a SerializerMethodResourceRelatedField(many=True) best open a new issue with a code example. Or even better a PR if you already see where the error lies. Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #151. Fixes #220.
I'd like some review and it'd be great if you could pull this into your project and give it a test drive.