Add LimitOffsetPagination #205
Merged
+130
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sarendsen nice work! I'd be happy to merge this in so that users have the option to enable it. We've been slowly switching to pytest style tests so this would be the proper place to add new tests: integration or unit |
|
hmmm, what's wrong with Travis ? |
|
Dunno, it's passing now though so they must have had an outage. |
|
Added a very basic unit test. The paginator has a lot of shared code with DRF. So DRF tests applies as well. If more needed let me know. |
|
@sarendsen thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While its not an official specification or requirement of the JSON API, DRF does provide support for limit/offset pagination and is widely used. So i think this might be an useful addition to this package, and can be used as optional paginator.
Limit and offset arguments are based on the pagination notes here: http://jsonapi.org/format/#fetching-pagination.
Examples:
I will write some unit test once one of the maintainers is oke with this going in.