Skip to content

Made docs/requirements.txt obsolete and install project itself #1134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 21, 2023

Conversation

sliverc
Copy link
Member

@sliverc sliverc commented Feb 21, 2023

Description of the Change

docs/requirements.txt was only introduced as it was only possible to configure one “requirements.txt” in the web interface. In the yaml file it is possible to add several, therefore removing docs/requirements.txt.

Additionally, this should solve the still persistent build error, as the project itself also needs to be installed.

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

docs/requirements.txt was only introduced as it was only possible
to configure one requirements in the web interface.
In the yaml file it is possible to add several therefore removing
docs/requirements.txt
@sliverc sliverc requested a review from n2ygk February 21, 2023 12:52
@n2ygk n2ygk merged commit 5c88b93 into django-json-api:main Feb 21, 2023
@sliverc sliverc deleted the install_self branch February 21, 2023 13:06
@sliverc
Copy link
Member Author

sliverc commented Feb 21, 2023

Thanks for merging those PRs. Finally, the RTD build is passing again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants