Skip to content

Unified tox configuration #1113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 12, 2022
Merged

Unified tox configuration #1113

merged 2 commits into from
Dec 12, 2022

Conversation

sliverc
Copy link
Member

@sliverc sliverc commented Dec 8, 2022

Description of the Change

  • Followed example of DRF using -f cmd line of tox v4 instead of tox-py
  • For linting jobs updated to Python 3.8 as will be required by future updates of Flake8
  • Added missing black job

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

* Followed example of DRF using -f cmd line of tox v4 instead of tox-py
* For linting jobs updated to Python 3.8 as will be required
  by future updates of Flake8
* Added missing black job
@sliverc
Copy link
Member Author

sliverc commented Dec 8, 2022

Something seems wrong with the Python 3.7 pipeline as it is now also testing Django 4.0 which it should not. I have to look into this again before this PR is ready.

@sliverc sliverc marked this pull request as draft December 8, 2022 19:44
@sliverc sliverc marked this pull request as ready for review December 12, 2022 17:59
@sliverc
Copy link
Member Author

sliverc commented Dec 12, 2022

I have found the error. With tox v4, the too broad definition of ignore test outcomes caused the issue that some testenv were run which should not have. I updated it accordingly and now it works as expected even with v4.

@sliverc sliverc requested a review from n2ygk December 12, 2022 18:00
@n2ygk n2ygk merged commit caccd48 into django-json-api:main Dec 12, 2022
@sliverc sliverc deleted the tox_v4 branch December 12, 2022 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants