Skip to content

Avoided using same related name twice in tests models #1086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 6, 2022

Conversation

sliverc
Copy link
Member

@sliverc sliverc commented Sep 6, 2022

Description of the Change

When calling makemigrations errors were raised as of conflict with related names. No test actually relied on this naming, so this PR cleans it up. I bumped into this when working on #1048 and could not create a migration without this change.

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

Sorry, something went wrong.

@sliverc sliverc requested a review from n2ygk September 6, 2022 21:06
@n2ygk n2ygk merged commit cbf52a3 into django-json-api:main Sep 6, 2022
@sliverc sliverc deleted the invalid_related_name branch September 7, 2022 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants