Skip to content

Analyse JSON API Version 1.1 RC 1 #547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sliverc opened this issue Jan 7, 2019 · 14 comments
Closed

Analyse JSON API Version 1.1 RC 1 #547

sliverc opened this issue Jan 7, 2019 · 14 comments

Comments

@sliverc
Copy link
Member

sliverc commented Jan 7, 2019

New release candidate of JSON API specification has been released.

There is now also a changelog to be reviewed at https://jsonapi.org/#update-history

A quickly browsed through it and it seems a few small changes would be needed to be done in DJA.

Opening this issue as a task to analyze what single steps needs to be done in DJA to support 1.1. Best is to open a new each for each single task.

@n2ygk
Copy link
Contributor

n2ygk commented Jan 7, 2019

@sliverc Thanks for following these updates with JSON API. I've reviewed the release notes and created an issue for each item. Note that it is not yet a release but a release candidate, so there's always some chance there will be further changes before the official release. Now is a good time to review these and see what work is required. The planned release date is January 31, 2019.

Should I create a milestone to track this? We don't necessarily have to include all these items in a new release though....

@sliverc
Copy link
Member Author

sliverc commented Jan 14, 2019

from jsonapi.org:

JSON:API v1.1 RC1 has been published! Please review and try out this upcoming version of the spec before its planned release date of January 31, 2019.

Keeping this in mind we can discuss the different issues in its respective issue. If there are still questions concerning specification we should raise it to the jsonapi.org in time. After this deadline has passed I guess we can implement the different issues as time permits (without having a milestone).

@auvipy
Copy link
Contributor

auvipy commented May 24, 2019

we can start work on this now

@sliverc
Copy link
Member Author

sliverc commented May 24, 2019

Even thought the date has passed long ago version 1.1 has not officially been released yet (hint still set on https://jsonapi.org/)

But of course it would be good to get started with those issues if someone has time at hand as the spec won't change much from what it is now.

@auvipy
Copy link
Contributor

auvipy commented May 24, 2019

any suggestions for me on how can i update them in current code?

@sliverc
Copy link
Member Author

sliverc commented May 27, 2019

#553 might be an easy one to start with.

@n2ygk
Copy link
Contributor

n2ygk commented Aug 12, 2019

FYI - JSONAPI 1.1 has reverted to a working draft so hold off on any implementation work. See json-api/json-api#1403 (comment)

@sliverc
Copy link
Member Author

sliverc commented Aug 15, 2019

Interesting what's happening with the spec. I guess we have enough tasks at hand anyway so can easily wait... 😄 it seems though the spec might mainly change around profiles though.

@sliverc
Copy link
Member Author

sliverc commented Oct 3, 2019

@n2ygk
It seems like the JSON API spec 1.1 won't be released anytime soon. There are now quite a few 1.1 issues cluttered in our database which we cannot really resolve. I would prefer we close them and once it is clear what to implement we can always reopen them again. What do you think?

@sliverc
Copy link
Member Author

sliverc commented Oct 4, 2019

Closing as explained at #547 (comment)

Once JSON API spec is moving forward we need to double check which issue need to be reopened.

@sliverc sliverc closed this as completed Oct 4, 2019
@auvipy
Copy link
Contributor

auvipy commented Aug 21, 2020

  • 2020-08-20: 1.1 Release candidate 2 released.

@auvipy
Copy link
Contributor

auvipy commented Aug 21, 2020

We can re-open this & analyze JSON-API 1.1 RC2 and modify the related closed issues. it seems with new extensions and other overhauls it is not so far from release this time.

@sliverc
Copy link
Member Author

sliverc commented Aug 21, 2020

By the experience we had with the RC1 where we put quite a bit of work into analyzing what needs to be done in DJA and then quite a few changes were made again in the specification I suggest we leave this closed till the specification is final. Especially when I look how in 1.1 RC2 extensions are defined it seems this is simply not finished yet.

Once 1.1 is final we need to specifically analyze what needs to be changed in DJA. An issue with a simple link to some feature won't be enough.

I want to encourage everyone to take part in the JSON API specification discussions though and think through it there.

This was referenced Aug 21, 2020
@auvipy
Copy link
Contributor

auvipy commented Aug 22, 2020

I do follow the modifications process and chime in where I feel. this can be opened to get traction IMHO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants