-
-
Notifications
You must be signed in to change notification settings - Fork 110
Add Generators.egressTimeBasedGenerator()
method that constructs TimedBasedGenerator
with a sensible choice of interface
#52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Generators.egressTimeBasedGenerator()
method that constructs TimedBasedGenerator
with a sensible choice of interface
#52
Conversation
* was not working when default IF was not the first interface returned * `EthernetAddress.fromInterface(nint)` will now return null if `nint` is null * removed unit tests that required both of IP4 and IP6 connectivity * mention the new factory method in the readme * minor documentation touch up
Generators.egressTimeBasedGenerator()
method that constructs TimedBasedGenerator
with a sensible choice of interface
Ok, this works better but somehow I get 2 local test failures that look like:
meaning, I think, that no "egress" interface is found on my Mac mini somehow. I won't revert this yet, since I think this is resolvable, and so I hope this can be done. Thank you once again for the contribution -- sort of exciting to add functionality to something I wrote originally 20 years ago! |
Yikes, maybe this is something better left in draft until it can be tested on a wider variety of platforms. @cowtowncoder what JDK are you using? |
@pgalbraith JDK 1.8.0_322 for the most part, although I will now try 11.0.15 to see if that behaves differently. Ok. So 11.0.15 (tem) has the same issue. Cannot try 17 since compilation (... for now) is for JDK 6. EDIT Filed #53 for JDK baseline boost as well; not really closely related to this but something that I had thought about earlier. |
Ok unfortunately I think the smart thing is to pull this until I can figure out what is happening. I'll write up a little diagnostic to see if we can dump out some useful info for troubleshooting. I briefly considered buying a Mac today, but then decided this wasn't worth risking my marriage :-D ... |
:-D It's ok, I think -- For now I think I'll just disable two failing tests but keep code around. And obviously won't be releasing anything until we know what to do here. |
Ok, unfortunately I will need to revert this, to be able to release 4.1.0 with other new features. |
This reverts commit 041cb79
This reverts commit 041cb79
This reverts commit dded1a2
Take # 2