Skip to content

Add Generators.egressTimeBasedGenerator() method that constructs TimedBasedGenerator with a sensible choice of interface #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 20, 2022

Conversation

pgalbraith
Copy link
Contributor

@pgalbraith pgalbraith commented Jun 18, 2022

Take # 2

pgalbraith and others added 2 commits August 14, 2021 14:02
* was not working when default IF was not the first interface returned
* `EthernetAddress.fromInterface(nint)` will now return null if `nint` is null
* removed unit tests that required both of IP4 and IP6 connectivity
* mention the new factory method in the readme
* minor documentation touch up
@cowtowncoder cowtowncoder merged commit 56043d1 into cowtowncoder:master Jun 20, 2022
@cowtowncoder cowtowncoder changed the title TimeBasedGenerator factory method that defaults to a sensible choice of interface Add Generators.egressTimeBasedGenerator() method that constructs TimedBasedGenerator with a sensible choice of interface Jun 20, 2022
cowtowncoder added a commit that referenced this pull request Jun 20, 2022
@cowtowncoder
Copy link
Owner

Ok, this works better but somehow I get 2 local test failures that look like:

[ERROR] Tests run: 21, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 0.026 s <<< FAILURE! - in com.fasterxml.uuid.EthernetAddressTest
[ERROR] testFromEgressInterface(com.fasterxml.uuid.EthernetAddressTest)  Time elapsed: 0.013 s  <<< FAILURE!
junit.framework.AssertionFailedError
	at com.fasterxml.uuid.EthernetAddressTest.testFromEgressInterface(EthernetAddressTest.java:1323)

[ERROR] testFromEgressInterfaceRoot(com.fasterxml.uuid.EthernetAddressTest)  Time elapsed: 0.002 s  <<< FAILURE!
junit.framework.AssertionFailedError
	at com.fasterxml.uuid.EthernetAddressTest.testFromEgressInterfaceRoot(EthernetAddressTest.java:1316)

meaning, I think, that no "egress" interface is found on my Mac mini somehow.

I won't revert this yet, since I think this is resolvable, and so I hope this can be done.

Thank you once again for the contribution -- sort of exciting to add functionality to something I wrote originally 20 years ago!

@pgalbraith
Copy link
Contributor Author

Yikes, maybe this is something better left in draft until it can be tested on a wider variety of platforms. @cowtowncoder what JDK are you using?

@cowtowncoder
Copy link
Owner

cowtowncoder commented Jun 20, 2022

@pgalbraith JDK 1.8.0_322 for the most part, although I will now try 11.0.15 to see if that behaves differently.

Ok. So 11.0.15 (tem) has the same issue. Cannot try 17 since compilation (... for now) is for JDK 6.

EDIT Filed #53 for JDK baseline boost as well; not really closely related to this but something that I had thought about earlier.

@pgalbraith
Copy link
Contributor Author

Ok unfortunately I think the smart thing is to pull this until I can figure out what is happening. I'll write up a little diagnostic to see if we can dump out some useful info for troubleshooting. I briefly considered buying a Mac today, but then decided this wasn't worth risking my marriage :-D ...

@cowtowncoder
Copy link
Owner

:-D

It's ok, I think -- For now I think I'll just disable two failing tests but keep code around. And obviously won't be releasing anything until we know what to do here.

@cowtowncoder
Copy link
Owner

Ok, unfortunately I will need to revert this, to be able to release 4.1.0 with other new features.

cowtowncoder added a commit that referenced this pull request Jan 8, 2023
cowtowncoder added a commit that referenced this pull request Jan 8, 2023
pgalbraith added a commit to pgalbraith/java-uuid-generator that referenced this pull request May 6, 2023
pgalbraith added a commit to pgalbraith/java-uuid-generator that referenced this pull request May 6, 2023
pgalbraith added a commit to pgalbraith/java-uuid-generator that referenced this pull request May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants