Skip to content

v2.5.0 #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 15, 2019
Merged

v2.5.0 #74

merged 5 commits into from
May 15, 2019

Conversation

xidedix
Copy link
Member

@xidedix xidedix commented May 15, 2019

v2.5.0
  • BREAKING CHANGE release for use with react-router-dom v5
    • feat(Breadcrumb2): mandatory prop router 💥 see: Breadcrumb
    • feat(SidebarNav2): mandatory prop router 💥 see: SidebarNav
  • refactor: demo update
  • refactor(SidebarNav): rename options prop for PerfectScrollbar
dependencies update
  • update react-router-dom to ^5.0.0 -> moved to peerDependencies

BREAKING CHANGES: 💥

  • removed react-router-dom from dependencies
  • deprecate 'Breadcrumb' in favour of Breadcrumb2
  • deprecate 'SidebarNav' in favour of SidebarNav2

usage in DefaultLayout.js:

import * as router from 'react-router-dom';
import { 
AppBreadcrumb2 as AppBreadcrumb
AppSidebarNav2 as AppSidebarNav
} from '@coreui/react';
// routes config
import routes from '../../routes.js';
...
<div className="app-body">
  <AppSidebar fixed display="lg">
    <AppSidebarNav navConfig={navigation} {...this.props} router={router}/>
    <AppSidebarMinimizer />
  </AppSidebar>
  <main className="main">
    <AppBreadcrumb appRoutes={routes} router={router}></AppBreadcrumb>
    ...
  </main>
  ...
</div>
...

xidedix added 5 commits May 15, 2019 19:31
- update `react-router-dom` to `^5.0.0` -> moved to `peerDependencies`
BREAKING CHANGE:
- inject `react-router-dom v5` to component
- usage
```
import * as router from 'react-router-dom';
...
<AppSidebarNav navConfig={navigation} {...this.props} router={router}/>
...
<AppBreadcrumb appRoutes={routes} router={router} />
```
BREAKING CHANGE:
- react-router-dom v5
@xidedix xidedix merged commit 0446a16 into master May 15, 2019
@xidedix xidedix deleted the dev-router-5 branch May 15, 2019 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant