-
Notifications
You must be signed in to change notification settings - Fork 2.6k
feat: update vfkit binary to v0.6.1 in macOS installer #25917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Florent Benoit <[email protected]>
related pr: #25608 |
/lgtm |
@cfergeau: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
We have to many images. What images are you referring to, the macos CI workers? I that case they still install from brew until we switch to Adrian's worker poll logic hopefully very soon. Then we just use whatever is in our installer so we can actually have proper test coverage of such installer changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benoitf, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Does this PR introduce a user-facing change?
I built the installer using
make ARCH=aarch64 NO_CODESIGN=1 pkginstaller
then I was able to init/start a machine