Skip to content

feat: update vfkit binary to v0.6.1 in macOS installer #25917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2025

Conversation

benoitf
Copy link
Contributor

@benoitf benoitf commented Apr 17, 2025

Does this PR introduce a user-facing change?

update vfkit binary to v0.6.1 in macOS installer

I built the installer using make ARCH=aarch64 NO_CODESIGN=1 pkginstaller

then I was able to init/start a machine

@baude
Copy link
Member

baude commented Apr 17, 2025

LGTM, @Luap99 do we need to also get this into our images?

@benoitf this should make 5.5 which starts RC next week.

@benoitf
Copy link
Contributor Author

benoitf commented Apr 18, 2025

related pr: #25608

@cfergeau
Copy link
Contributor

/lgtm

Copy link
Contributor

openshift-ci bot commented Apr 18, 2025

@cfergeau: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Luap99
Copy link
Member

Luap99 commented Apr 22, 2025

LGTM, @Luap99 do we need to also get this into our images?

We have to many images. What images are you referring to, the macos CI workers? I that case they still install from brew until we switch to Adrian's worker poll logic hopefully very soon. Then we just use whatever is in our installer so we can actually have proper test coverage of such installer changes.

Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2025
Copy link
Contributor

openshift-ci bot commented Apr 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benoitf, Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 22, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 3c6a593 into containers:main Apr 22, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants