update test/tools vendor and ginkgo #25560
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Update the tools to the latest version. Add a note that go-swagger cannot be updated to v0.31.0 to due go checksum mismatch. Signed-off-by: Paul Holzinger <[email protected]>
Signed-off-by: Paul Holzinger <[email protected]>
openshift-merge-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| @@ -53,7 +53,7 @@ require ( | |||
| github.com/moby/sys/user v0.3.0 | |||
| github.com/moby/term v0.5.2 | |||
| github.com/nxadm/tail v1.4.11 | |||
| github.com/onsi/ginkgo/v2 v2.22.2 | |||
| github.com/onsi/ginkgo/v2 v2.23.0 | |||
There was a problem hiding this comment.
In view of commit 6df50be, this needs to be updated to v2.23.3
(ideally, renovate should be configured to bump ginkgo in both places at once)
There was a problem hiding this comment.
The alternative is to drop this second copy entirely: #25732
There was a problem hiding this comment.
(ideally, renovate should be configured to bump ginkgo in both places at once)
It does, but it doesn't work when ginkgo gets updated due transitive updates, i.e. from c/common.
|
A friendly reminder that this PR had no activity for 30 days. |
That only changed ginkgo not the other deps. I don't know the cards but I believe someone is lookup into swagger alternatives (or ways to improve swagger) |
Does this PR introduce a user-facing change?