kube play: fix pull policy #19805
kube play: fix pull policy #19805
Conversation
openshift-ci
bot
added
release-note
approved
|
@edsantiago, PTAL at the tests. |
|
@vrothberg Afaics podman CI is blocked since some images on quay.io are missing. |
test/system/700-play.bats
Outdated
| $PODMAN --debug kube play $yaml_source 2>$stderr | ||
| if [[ $status != 0 ]]; then | ||
| cat $stderr | ||
| die "kube play failed: $output" |
There was a problem hiding this comment.
There is no $output from running $PODMAN.
I understand your reluctance to "pollute logs", but please remember that the logs are invisible unless there's an error. If there's an error, wouldn't we want to see full logs? It seems safer to stick with run_podman IMO.
There was a problem hiding this comment.
Ah, I wasn't aware. Will change, thanks!
Use the `newer` pull policy only for the "latest" tag and default to using `missing` otherwise. This speeds up `kube play` as it'll skip reaching out to the registry and also fixes other side-effects described in containers#19801. Fixes: containers#19801 Signed-off-by: Valentin Rothberg <[email protected]>
| _write_test_yaml command=true image=$local_image | ||
|
|
||
| run_podman --debug kube play $yaml_source | ||
| assert "$output" =~ "Pulling image $local_image \(policy\: newer\)" "pull policy is set to newhen pulling latest tag" |
There was a problem hiding this comment.
I could make a culturally insensitive remark here about wordstogethersmashing norms, but I won't. Oh, wait, I just did.
(Not worth re-pushing for. I kind of like it).
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: edsantiago, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@flouthoc PTAL |
|
@giuseppe PTAL |
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Use the
newerpull policy only for the "latest" tag and default to usingmissingotherwise. This speeds upkube playas it'll skip reaching out to the registry and also fixes other side-effects described in #19801.Fixes: #19801
Does this PR introduce a user-facing change?