Skip to content

Add progress bar for decompress image #19249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 19, 2023

Conversation

afbjorklund
Copy link
Contributor

Does this PR introduce a user-facing change?

Show progress bar when decompressing podman machine image

Closes #19240

@afbjorklund afbjorklund changed the title Decompress progress Add progress bar for decompress image Jul 15, 2023
@Luap99
Copy link
Member

Luap99 commented Jul 17, 2023

You need to add [NO NEW TESTS NEEDED] to your commit message in order to pass CI, I don't think we can test progress bars.

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. Tested it locally and I think it's a very nice improvement. Thanks!

@ashley-cui PTAL

@afbjorklund
Copy link
Contributor Author

afbjorklund commented Jul 17, 2023

I don't think we can test progress bars.

The way to test would be to have a machine readable output (from machine), with events and progress etc.

Currently it is just random prints, for humans.

One problem is that it requires a very large console (120+), in order to see the progress and not just filenames.

Signed-off-by: Anders F Björklund <[email protected]>
[NO NEW TESTS NEEDED]

Signed-off-by: Anders F Björklund <[email protected]>
@afbjorklund afbjorklund force-pushed the decompress-progress branch from c1375f5 to d8d600b Compare July 17, 2023 12:34
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund, vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 17, 2023
Copy link
Member

@ashley-cui ashley-cui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and progress bar LGTM, though it looks like it breaks one of our tests - we pass in /dev/null as an imagepath for one of our tests and the progress bar hangs because it's trying to copy 0b/0b.

@afbjorklund
Copy link
Contributor Author

Looks like it is a known issue: (with workaround)

[NO NEW TESTS NEEDED]

Signed-off-by: Anders F Björklund <[email protected]>
@TomSweeneyRedHat
Copy link
Member

LGTM
looks like the Windows test (known issue), is the only hangup here.

@rhatdan rhatdan merged commit 92d0233 into containers:main Jul 19, 2023
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Oct 18, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

podman machine image decompression needs a progress bar
6 participants