-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Add progress bar for decompress image #19249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
You need to add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM. Tested it locally and I think it's a very nice improvement. Thanks!
@ashley-cui PTAL
The way to test would be to have a machine readable output (from machine), with events and progress etc. Currently it is just random prints, for humans. One problem is that it requires a very large console (120+), in order to see the progress and not just filenames. |
Signed-off-by: Anders F Björklund <[email protected]>
[NO NEW TESTS NEEDED] Signed-off-by: Anders F Björklund <[email protected]>
c1375f5
to
d8d600b
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afbjorklund, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code and progress bar LGTM, though it looks like it breaks one of our tests - we pass in /dev/null as an imagepath for one of our tests and the progress bar hangs because it's trying to copy 0b/0b.
Looks like it is a known issue: (with workaround) |
[NO NEW TESTS NEEDED] Signed-off-by: Anders F Björklund <[email protected]>
LGTM |
Does this PR introduce a user-facing change?
Closes #19240