Support label_users in buildah #6161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: containers#6160 label_users tells buildah and podman to maintain the user and role from the SELinux label, the default is to change the user and role to system_u:system_r. With this change we end up with an unconfined_u user running the container as unconfined_u:unconfined_r. I don't believe our CI/CD system can test this, because it runs with system_u:system_r by default. Signed-off-by: Daniel J Walsh <[email protected]>
rhatdan
added
the
No New Tests
|
Code was taken from podman, might want to eventually move to common. |
|
Ephemeral COPR build failed. @containers/packit-build please check. |
flouthoc
approved these changes
May 6, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, giuseppe, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit cd2bb61
into
containers:main
32 of 37 checks passed
nalind
reviewed
May 6, 2025
| } | ||
| con, err := selinux.NewContext(label) | ||
| if err != nil { | ||
| return nil, err |
There was a problem hiding this comment.
This really should have been wrapped with more context somewhere in the call stack - the only error this can return just says "invalid label".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #6160
label_users tells buildah and podman to maintain the user and role from the SELinux label, the default is to change the user and role to system_u:system_r.
With this change we end up with an unconfined_u user running the container as unconfined_u:unconfined_r.
I don't believe our CI/CD system can test this, because it runs with system_u:system_r by default.
What type of PR is this?
What this PR does / why we need it:
How to verify it
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?