breakup containerImageRef.NewImageSource #6159
Conversation
openshift-ci
bot
added
the
kind/cleanup
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: hanwen-flow The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Ephemeral COPR build failed. @containers/packit-build please check. |
|
@hanwen-flow thanks for the PR. Looks like your branch needs an update, and there are all kinds of failing tests. |
hanwen-flow
force-pushed
the
hanwen/saveblob
branch
from
160111b to
0b725c4
Compare
you folks need to fix your CI: This PR doesn't introduce new functionality, hence no new tests (somebody with permissions has to set a label on this PR) |
No functional changes, hence no test updates. Signed-off-by: Han-Wen Nienhuys <[email protected]>
This shortens the huge function containerImageRef.NewImageSource. No further code changes; no functional changes (hence, no tests). Signed-off-by: Han-Wen Nienhuys <[email protected]>
No functional changes (hence, no tests). Signed-off-by: Han-Wen Nienhuys <[email protected]>
This reduces NewImageSource() complexity Signed-off-by: Han-Wen Nienhuys <[email protected]>
Signed-off-by: Han-Wen Nienhuys <[email protected]>
hanwen-flow
force-pushed
the
hanwen/saveblob
branch
from
0b725c4 to
9063978
Compare
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
containerImageRef.NewImageSource is hard to follow because it is large; this reduces complexity a bit
container commit is bottlenecked (among others) by running the layer blob through sha256, which is single-threaded. This refactoring is a preparation to split the blob into multiple streams which can be processed in parallel (not part of this PR).
How to verify it
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Does this PR introduce a user-facing change?
no.