.github: check_cirrus_cron work around github bug #6120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So I wondered why our email workflow only reported things for podman... It seems the secrets: inherit is broken and no longer working, I see all jobs on all repos failing with: Error when evaluating 'secrets'. .github/workflows/check_cirrus_cron.yml (Line: 19, Col: 11): Secret SECRET_CIRRUS_API_KEY is required, but not provided while calling. This makes no sense to me I doubled checked the names, nothing changed on our side and it is consistent for all projects. Interestingly this same thing passed on March 10 and 11 (on all repos) but failed before and after this as well. Per[1] we are not alone, anyway let's try to get this working again even if it means more duplication. [1] actions/runner#2709 Signed-off-by: Paul Holzinger <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
/hold |
|
Total success is green with two integration tests still running? That doesn't seem right... |
openshift-merge-bot
bot
merged commit 0db4755
into
containers:main
27 of 37 checks passed
That is most certainly not right, likely miss configured dependencies in cirrus.yml. Anyway I am not worried about this particular PR breaking anything cirrus related so it should be fine. |
openshift-merge-bot bot
pushed a commit
that referenced
this pull request
Apr 16, 2025
As discovered by Matt[1], without this we could merge PRs even if they have failing rootless integration tests. [1] #6120 (comment) Signed-off-by: Paul Holzinger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I wondered why our email workflow only reported things for podman...
It seems the secrets: inherit is broken and no longer working, I see all jobs on all repos failing with:
Error when evaluating 'secrets'. .github/workflows/check_cirrus_cron.yml (Line: 19, Col: 11): Secret SECRET_CIRRUS_API_KEY is required, but not provided while calling.
This makes no sense to me I doubled checked the names, nothing changed on our side and it is consistent for all projects. Interestingly this same thing passed on March 10 and 11 (on all repos) but failed before and after this as well.
Per[1] we are not alone, anyway let's try to get this working again even if it means more duplication.
[1] actions/runner#2709
What type of PR is this?
What this PR does / why we need it:
How to verify it
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?