[release-1.39] createPlatformContainer: drop MS_REMOUNT|MS_BIND #6089
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When attempting to change the mount propagation of the old root directory tree before unmounting it, it's enough that we pass the requested propagation flags. In particular, MS_REC is the only flag that is supposed to be allowed to be specified along with a mount propagation flag, but in practice it was only triggering an error some of the time, and CI wasn't one of those times. The added test mounts the root filesystem as an overlay and then runs buildah as a rootless user on top of that, which is more comparable to a root-on-composefs configuration, which manages to trigger the error. Signed-off-by: Nalin Dahyabhai <[email protected]>
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nalind, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
openshift-merge-bot
bot
merged commit c637c8e
into
containers:release-1.39
33 checks passed
TomSweeneyRedHat
added a commit
to TomSweeneyRedHat/buildah
that referenced
this pull request
Mar 26, 2025
Create Bulidah v1.39.4 in order to get the fix from containers#6089 into that version of the release. This will fix a mount flags issue that @nalind discovered and squashed. This is an important fix for Image Mode in RHEL 9.6 and 10.0. Fixes: https://issues.redhat.com/browse/RHEL-85114, https://issues.redhat.com/browse/RHEL-85115 Signed-off-by: tomsweeneyredhat <[email protected]>
TomSweeneyRedHat
added a commit
to TomSweeneyRedHat/buildah
that referenced
this pull request
Mar 26, 2025
Create Bulidah v1.39.4 in order to get the fix from containers#6089 into that version of the release. This will fix a mount flags issue that @nalind discovered and squashed. This is an important fix for Image Mode in RHEL 9.6 and 10.0. Fixes: https://issues.redhat.com/browse/RHEL-85114, https://issues.redhat.com/browse/RHEL-85115 Signed-off-by: tomsweeneyredhat <[email protected]>
This was referenced Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #6088
/assign nalind