Fix Conformance tests on ARM64 #5990
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
nalind
reviewed
Feb 18, 2025
nalind
reviewed
Feb 18, 2025
nalind
reviewed
Feb 18, 2025
nalind
reviewed
Feb 18, 2025
Honny1
force-pushed
the
fix-arm64
branch
7 times, most recently
from
d2c64f5 to
e6f4d21
Compare
|
@nalind I have vendored a new version of |
This fixes getting of cpu variants for ARM64 Fixes the TestConformance/setuid-file-in-archive test on ARM64. Signed-off-by: Jan Rodák <[email protected]>
New imagebuilder contains fix that sets empty TARGETVARIANT and BUILDVARIANT. Docker does not set these values for ARM64. This fixes the TestConformance/multistage-builtin-args and TestConformance/builtins tests on ARM64. Signed-off-by: Jan Rodák <[email protected]>
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Honny1, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/kind failing-test
What this PR does / why we need it:
This PR fixes bugs discovered by running Conformance tests on ARM64.
Fixed tests:
TestConformance/setuid-file-in-archiveTestConformance/multistage-builtin-argsTestConformance/builtinsHow to verify it
Execute Conformance tests on ARM system.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Does this PR introduce a user-facing change?